Restore serialization of dropped runtime-generated functions - #138
Merged
ChrisRackauckas merged 1 commit intoJul 31, 2026
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 30, 2026
Member
Author
|
The sole failed check here is an independent clean-master Documentation regression, not part of the serialization diff. Current master fails identically at dependency installation: https://github.com/SciML/RuntimeGeneratedFunctions.jl/actions/runs/30408235778 An actual Pkg-based bisect identified #137 ( |
ChrisRackauckas
marked this pull request as ready for review
July 31, 2026 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until reviewed by @ChrisRackauckas.
Summary
RuntimeGeneratedFunctions afterdrop_exprSerialization.serialize/deserializeAPIRoot cause
#136 removed the dropped-function serializer while migrating strict QA because it called the non-public
Serialization.serialize_type. #137 then released that behavioral break as v0.5.23. ModelingToolkitBase has intentionally dropped generated-function bodies since April 2025, so its clean-master distributed test began failing when the worker deserialized an RGF produced in another process. The first bad source commit is6550973d9290c906b1f61d37d416695e95e63a7c; v0.5.22 is the passing dependency control.This implementation avoids the non-public API that motivated the removal.
Validation
julia +1.10 --project=. -e 'using Pkg; Pkg.test()'julia +1.12 --project=. -e 'using Pkg; Pkg.test()'--check --diff .d39174937fead779b29fa5baa50ba975adbde8c9, Julia 1.10, officialGROUP=Extended:ArgumentError: cannot deserialize a dropped RuntimeGeneratedFunctionDistributed TestDistributed Testand the full Extended groupDownstream failure: SciML/ModelingToolkit.jl#4852.